Restored Killed console message #1
Conversation
|
Hi @rjperes, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! TTYL, DNFBOT; |
Added Started console message Captured possible exception from node process
| protected virtual void OnBeforeLaunchProcess() { | ||
| } | ||
|
|
||
| protected virtual void OnOutputDataReceived(string outputData) { | ||
| Console.WriteLine("[Node] " + outputData); | ||
| } | ||
|
|
There was a problem hiding this comment.
The only thing I hate about VS code....
There was a problem hiding this comment.
You mean, the whitespaces? Arrrgghhh...
There was a problem hiding this comment.
If I get rid of them, will you merge? :-)
There was a problem hiding this comment.
It was just a random comment, sorry. I only saw a demo of this thing during the MVP summit and it was very cool so I got interested. @SteveSanderson needs to look at it I think.
There was a problem hiding this comment.
Yeah, he's right here with me! :-)
|
Thanks! I've merged some of the changes here (the better logging of Node startup failures, and the whitespace fixes). I didn't merge the console messages that were being issued on successful Node process startup or shutdown, since we don't want to produce extra log messages if everything is OK. |
Added Started console message
Captured possible exception from node process